This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
feat: implement getting identities by multiple public keys hashes #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
reviewed
Oct 5, 2020
| const identityId = await publicKeyIdentityIdRepository.fetch(publicKeyHash); | ||
|
|
||
| if (!identityId) { | ||
| return null; |
shumkov
reviewed
Oct 5, 2020
| async function identityIdsByPublicKeyHashesQueryHandler(params, { publicKeyHashes }) { | ||
| const identityIds = await Promise.all( | ||
| publicKeyHashes.map(async (publicKeyHash) => ( | ||
| publicKeyIdentityIdRepository.fetch(publicKeyHash) |
There was a problem hiding this comment.
Check for null and return empty buffer in this case
|
This pull request introduces 1 alert when merging 9a2a902 into 072c5fe - view on LGTM.com new alerts:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Adding method to get multiple
identityand its ids by multiple public key hashes.What was done?
Added method to get multiple
identityand its ids by multiple public key hashes.How Has This Been Tested?
Unit tests.
Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only