-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: simplified public key to identity structure #437
Conversation
This pull request fixes 2 alerts when merging 7844c0f into 748320c - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging 2dbc228 into 748320c - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging 95e9117 into 748320c - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging 3415c92 into 748320c - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging a17e5e5 into 748320c - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging 44b90c9 into 748320c - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging a8d5736 into 748320c - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging bd9f0fb into 748320c - view on LGTM.com fixed alerts:
|
Issue being fixed or feature implemented
This is preliminary work for the GroveDB proofs integration. The existing structure of the public key to identity IDs structure has several downsides:
Removal of unused
getIdentityIdsByPublicKeyHash
endpoint and using GroveDB references solve those problems.What was done?
getIdentityIdsByPublicKeyHash
endpoint.StateRepository#storeIdentity
toStateRepository#createIdentity
andStateRepository#updateIdentity
to remove extra read operation.0
to allow future substructures connected to identityHow Has This Been Tested?
Breaking Changes
getIdentityIdsByPublicKeyHash
endpoint is removed.getIdentitiesByPublicKeyHash
now responds with an array of identities, instead of an array of cbored arrays of identities.Checklist:
For repository code-owners and collaborators only