Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Cleanup #31

Merged
merged 6 commits into from
Sep 21, 2020
Merged

Release Cleanup #31

merged 6 commits into from
Sep 21, 2020

Conversation

benjamin-t-frost
Copy link
Contributor

Changes

  • Made launchdarkly-js-client-sdk a peer dependency
  • Declared no side effects for bundlephobia

@codecov
Copy link

codecov bot commented Sep 20, 2020

Codecov Report

Merging #31 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #31   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files           9        9           
  Lines          78       78           
  Branches       17       17           
=======================================
  Hits           71       71           
  Misses          6        6           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18cf3cb...34f5a71. Read the comment docs.

"lodash": "^4.17.19"
}
},
"peerDependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was worried when I saw you deleted the dependency for launchdarkly 😂 This makes sense though.

@benjamin-t-frost benjamin-t-frost merged commit 67dedb5 into dev Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants