Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Cleanup #31

Merged
merged 6 commits into from
Sep 21, 2020
Merged

Release Cleanup #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7512af6
Cleanup package for next release
Sep 20, 2020
1cd505c
Never going to want to commit package dir
Sep 20, 2020
55c8b0c
Made LD a peer dependency & declared side effect free
Sep 20, 2020
4e169d1
Updated readme re peer dependency installation
Sep 20, 2020
dc9d073
end of file line
Sep 20, 2020
34f5a71
Version bump
Sep 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,4 +188,6 @@ fabric.properties
# Ignore all local history of files
.history

# End of https://www.toptal.com/developers/gitignore/api/node,visualstudiocode,pycharm
# End of https://www.toptal.com/developers/gitignore/api/node,visualstudiocode,pycharm

package/
5 changes: 4 additions & 1 deletion .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
_config.yml
_layouts/
.codecov.yml
.editorconfig
.env
.eslintrc
.github/
.idea/
.prettierrc
*.tgz
.vscode/
babel.config.js
coverage/
jest.config.js
node_modules/
rollup.config.js
package/
rollup.config.js
src/
tests/
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
[![codecov](https://img.shields.io/codecov/c/github/dashhudson/vue-ld/dev?color=%23d6b034)](https://codecov.io/gh/dashhudson/vue-ld) [![npm version](https://img.shields.io/npm/v/vue-ld?color=%23d6b034)](https://www.npmjs.com/package/vue-ld) [![Last Commit](https://img.shields.io/github/last-commit/dashhudson/vue-ld?color=%23d6b034)](https://github.com/dashhudson/vue-ld/graphs/commit-activity)
[![Licence](https://img.shields.io/github/license/dashhudson/vue-ld?color=%23d6b034)](https://github.com/dashhudson/vue-ld/blob/dev/LICENSE.txt) [![Stars](https://img.shields.io/github/stars/dashhudson/vue-ld?color=%23d6b034&logoColor=%23d6b034)](https://github.com/dashhudson/vue-ld)

A simple wrapper around the [js-client-sdk](https://github.com/launchdarkly/js-client-sdk) that provides observable feature flags, a ready state to ensure all feature flags are up to date, and other utilities.
A simple wrapper around the [js-client-sdk](https://github.com/launchdarkly/js-client-sdk) that provides observable feature flags, a ready state to ensure all feature flags are up to date, and routing utilities.

## Usage

### Installation

```bash
$ npm install --save vue-ld
$ npm install --save vue-ld launchdarkly-js-client-sdk
```

Main.js
Expand Down
42 changes: 21 additions & 21 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vue-ld",
"version": "0.1.5",
"version": "0.1.6",
"description": "A Vue.js wrapper for the LaunchDarkly SDK for Browser JavaScript",
"main": "dist/index.cjs.js",
"module": "dist/index.es.js",
Expand Down Expand Up @@ -51,6 +51,7 @@
"eslint-plugin-prettier": "^3.1.4",
"eslint-plugin-vue": "^6.2.2",
"jsdom": "^16.3.0",
"launchdarkly-js-client-sdk": "^2.18.1",
"prettier": "^2.0.5",
"rollup": "^2.23.0",
"rollup-plugin-vue": "^5.1.9",
Expand All @@ -61,7 +62,10 @@
"vue-template-compiler": "^2.6.11"
},
"dependencies": {
"launchdarkly-js-client-sdk": "^2.18.0",
"lodash": "^4.17.19"
}
},
"peerDependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was worried when I saw you deleted the dependency for launchdarkly 😂 This makes sense though.

"launchdarkly-js-client-sdk": "^2.18.1"
},
"sideEffects": false
}