Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement memory-copy only of G1Element and G2Element #74

Merged
merged 2 commits into from
Apr 21, 2023
Merged

feat: implement memory-copy only of G1Element and G2Element #74

merged 2 commits into from
Apr 21, 2023

Conversation

PastaPastaPasta
Copy link
Member

extend it out to bindings as well

@PastaPastaPasta PastaPastaPasta mentioned this pull request Apr 21, 2023
Open
@UdjinM6
Copy link

UdjinM6 commented Apr 21, 2023

Looks good but this should probably be submitted to upstream instead/first.

UdjinM6
UdjinM6 approved these changes Apr 21, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK to merge now assuming a similar PR to upstream is going to be submitted 🔜 (we can revert it later in case upstream devs would find an issue with this approach - it's only develop after all :) )

@PastaPastaPasta
Copy link
Member Author

PR created here: Chia-Network#364; merging

@PastaPastaPasta PastaPastaPasta merged commit 37c5314 into develop Apr 21, 2023
17 of 27 checks passed
@UdjinM6 UdjinM6 deleted the feat/clone branch May 10, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PastaPastaPasta @UdjinM6