feat: implement memory-copy only of G1Element and G2Element #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that we've completed some needed housekeeping, could you rebase so we can get a clean CI and get this in? Thanks very much for your upstream! -Gene |
arvidn
requested changes
May 8, 2023
| @@ -59,6 +59,7 @@ class G1Element { | |||
| GTElement Pair(const G2Element &b) const; | |||
| uint32_t GetFingerprint() const; | |||
| std::vector<uint8_t> Serialize() const; | |||
| G1Element Copy(); | |||
There was a problem hiding this comment.
in C++, this functionality is implemented by copy constructors. I can't see a good reason to have this be a member function instead. But, if there is a good reason, it should at least be a const member function
|
Closing PR - this isn't required due to the implicit C++ copy constructors, which are already in memory (essentially a memcpy) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a performant memory-only copy for G1Element and G2Element; I don't have benchmarks, but when we used this we saw significant performance improvements.