fix: Arabic decimals #1174
Merged
fix: Arabic decimals #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syn-McJ
commented
Jul 27, 2023
| } else { | ||
| fiatValue.replace(",".toRegex(), ".") | ||
| fiatValue.replace(",", ".") | ||
| .replace("٫", ".") |
There was a problem hiding this comment.
At first, I wanted to parse the input in a "proper" manner with the current device locale, however, this proved problematic because formatFiatWithoutComma often receives input in US format.
At some point, we might want to unify the way decimal separators are presented to the users in different locales, but it will require a bit of work and extensive testing. For now, this fix should suffice.
HashEngineering
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Arabic locales, there is a different comma character used as a decimal separator, which is distinct from the comma in other locales. This causes a crash in the Amount Input control.
Issue being fixed or feature implemented
formatFiatWithoutCommalogicRelated PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: