Do not hold cs_vNodes in CSigSharesManager::SendMessages() for too lo…

…ng (#2758)
dashpay · Mar 11, 2019 · 3a5e7c4 · 3a5e7c4
1 parent fbf0dcb
commit 3a5e7c4
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/llmq/quorums_signing_shares.cpp b/src/llmq/quorums_signing_shares.cpp
@@ -1059,7 +1059,9 @@ bool CSigSharesManager::SendMessages()
 
     bool didSend = false;
 
-    g_connman->ForEachNode([&](CNode* pnode) {
+    std::vector<CNode*> vNodesCopy = g_connman->CopyNodeVector(CConnman::FullyConnectedOnly);
+
+    for (auto& pnode : vNodesCopy) {
         CNetMsgMaker msgMaker(pnode->GetSendVersion());
 
         auto it1 = sigSessionAnnouncements.find(pnode->id);
@@ -1145,9 +1147,10 @@ bool CSigSharesManager::SendMessages()
                 didSend = true;
             }
         }
+    }
 
-        return true;
-    });
+    // looped through all nodes, release them
+    g_connman->ReleaseNodeVector(vNodesCopy);
 
     if (didSend) {
         g_connman->WakeSelect();