Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.12.0.x [build] fix deprecated download paths #1219

Merged
merged 2 commits into from Dec 21, 2016
Merged

Conversation

schinzelh
Copy link

@schinzelh schinzelh commented Dec 21, 2016

Some download paths have changed for (old) dependencies - fixed

  • googlecode is deprecated, moved to github
  • Qt5.2 moved to download archive

@schinzelh schinzelh changed the title V0.12.0.x [build] fix protobuf download V0.12.0.x [build] fix deprecated download paths Dec 21, 2016
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both checks failed for win64 with

Program: Z:\home\travis\build\dashpay\dash\dash-x86_64-w64-mingw32\src\test\test_dash.exe
File: random.cpp, Line 89

which is "assert" line here:

void GetRandBytes(unsigned char* buf, int num)
{
    if (RAND_bytes(buf, num) != 1) {
        LogPrintf("%s: OpenSSL RAND_bytes() failed with error: %s\n", __func__, ERR_error_string(ERR_get_error(), NULL));
        assert(false);
    }
}

i.e smth wrong with openssl.

On another note all other jobs in travis builds succeeded 👍
utACK

@UdjinM6 UdjinM6 merged commit 13d1944 into v0.12.0.x Dec 21, 2016
@schinzelh
Copy link
Author

schinzelh commented Dec 21, 2016

Maybe backporting this will fix it?

bitcoin@628cf14

bitcoin#7891

@schinzelh schinzelh deleted the v0.12.0.x_ping branch December 21, 2016 08:23
@UdjinM6
Copy link

UdjinM6 commented Dec 21, 2016

There is a fallback to OS RNG in btc 0.13 which we don't have and most likely there are also some other changes related to this, so I wouldn't mess with that too much tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants