Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copying of final binaries into dashcore-binaries #2090

Merged
merged 2 commits into from
May 31, 2018
Merged

Fix copying of final binaries into dashcore-binaries #2090

merged 2 commits into from
May 31, 2018

Conversation

codablock
Copy link

No description provided.

schinzelh
schinzelh approved these changes May 30, 2018
View reviewed changes
Copy link

@schinzelh schinzelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, some legacy stuff :)

utACK

@UdjinM6 UdjinM6 added this to the 12.3 milestone May 30, 2018
UdjinM6
UdjinM6 approved these changes May 30, 2018
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

nmarley
nmarley approved these changes May 31, 2018
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock
Copy link
Author

Had to add another commit to fix more file names in gitian descriptors

UdjinM6
UdjinM6 approved these changes May 31, 2018
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@codablock codablock merged commit 7b43720 into dashpay:develop May 31, 2018
@codablock codablock deleted the pr_gitian_fix_mv_binaries branch May 31, 2018 15:31
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@codablock @andvgal
Fix copying of final binaries into dashcore-binaries (dashpay#2090)
0577196 
* Fix copying of final binaries into dashcore-binaries

* Fix binary names in gitian-osx-signer.yml and gitian-win-signer.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schinzelh schinzelh schinzelh approved these changes

@nmarley nmarley nmarley approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codablock @schinzelh @nmarley @UdjinM6