-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not send excessive messages in governance sync #2124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should fix the log message before merging this (commented inline)
000e8c3
to
71916e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
I checked the code once again and I'm still not 100% sure if this PR breaks smth or not. Postponing it till 12.4, needs more testing IMO. |
71916e8
to
72b639c
Compare
72b639c
to
06ed62c
Compare
Reviving this. Rebased and slightly tested by connecting one patched node with no data directly to another patched one, seems to be working as expected. |
No need to send gobject inv for a single gobject, the other node already knows it, so send votes only. Also, no need to send "fake" stats like "0 votes" when syncing gobjects and "1 object" when syncing votes. Rename functions accordingly.
06ed62c
to
0893567
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
- Related to dashpay/dash#2124
* Guide - PrivateSend updates - Variable paticipant count - Link updates * Guide - MN sync reorg - Move all content regarding old mn sync system to a subsection * Guide - Governance sync update - Related to dashpay/dash#2124 * Content - Remove governance watchdog references - Related to dashpay/dash#2816 * Content - Governance sync update * Content - Update Dash Core version and protocol number * Formatting fix * Content - Disclaimer and roadmap link * Content - Update Sentinel info to indicate deprecation of sentinelping * Formatting fix
* Guide - PrivateSend updates - Variable paticipant count - Link updates * Guide - MN sync reorg - Move all content regarding old mn sync system to a subsection * Guide - Governance sync update - Related to dashpay/dash#2124 * Content - Remove governance watchdog references - Related to dashpay/dash#2816 * Content - Governance sync update * Content - Update Dash Core version and protocol number * Formatting fix * Content - Disclaimer and roadmap link * Content - Update Sentinel info to indicate deprecation of sentinelping * Formatting fix
* Guide - PrivateSend updates - Variable paticipant count - Link updates * Guide - MN sync reorg - Move all content regarding old mn sync system to a subsection * Guide - Governance sync update - Related to dashpay/dash#2124 * Content - Remove governance watchdog references - Related to dashpay/dash#2816 * Content - Governance sync update * Content - Update Dash Core version and protocol number * Formatting fix * Content - Disclaimer and roadmap link * Content - Update Sentinel info to indicate deprecation of sentinelping * Formatting fix
No need to send gobject inv for a single gobject, the other node already knows it, so send votes only. Also, no need to send "fake" stats like "0 votes" when syncing gobjects and "1 object" when syncing votes. And finally, rename functions accordingly.
EDIT:
PS. Haven't assigned milestone for now - should be safe to merge in 12.3 IMO, but this PR changes the actual behaviour while (strictly saying) it doesn't fix a critical bug or smth, just removes some excessive/redundant parts, so I'm open for other opinions/arguments.