[rpc] getblockchaininfo: add size_on_disk, prune_target_size, automat… #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic_pruning Fix pruneheight help text. Move fPruneMode block to match output ordering with help text. Add functional tests for new fields in getblockchaininfo.
nmarley
reviewed
Nov 4, 2018
| obj.push_back(Pair("pruneheight", block->nHeight)); | ||
|
|
||
| // if 0, execution bypasses the whole if block. | ||
| bool automatic_pruning = (gArgs.GetArg("-prune", 0) != 1); |
There was a problem hiding this comment.
Need to remove gArgs here, which isn't implemented yet in Dash.
|
Pls specify PR(s) you backported. |
|
Backports bitcoin#11367 |
|
Looks like you have to backport at least bitcoin#11370 first. Also, test folders were reorged in bitcoin#9956, we haven't backported this one yet (the corresponding file in our version/repo is In general, (with ^^^ in mind) not sure if fixing #2391 right now instead of waiting for future backport packs is a good idea. Thoughts @codablock ? |
|
Let's put this on hold for the moment, lets implement these backports for 0.13.x or 1.0 but not 0.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[rpc] getblockchaininfo: add size_on_disk, prune_target_size, automatic_pruning
Fix pruneheight help text.
Move fPruneMode block to match output ordering with help text.
Add functional tests for new fields in getblockchaininfo.That file was deleted in the dash branch, so the tests were not backportedfixes #2391