Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify "protx list" options #2559

Merged
merged 1 commit into from Dec 17, 2018
Merged

Unify "protx list" options #2559

merged 1 commit into from Dec 17, 2018

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Dec 17, 2018

Two reasons:

  1. it's confusing to have different options in different order for pretty similar commands
  2. it's inconvenient to search for current block height all the time before submitting a command (and I guess it's the default use case)

@UdjinM6 UdjinM6 added this to the 13.0 milestone Dec 17, 2018
codablock
codablock approved these changes Dec 17, 2018
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👍
Was annoyed by this inconsistency as well tbh :)

@codablock
Copy link

@strophy @thephez might be needed to change docs as well.

@codablock codablock merged commit c089261 into dashpay:develop Dec 17, 2018
thephez added a commit to dash-docs/dash-docs that referenced this pull request Dec 17, 2018
@thephez
RPC - Update protx list
7348fe5 
Make all options follow the same parameter format (dashpay/dash#2559)
thephez added a commit to dash-docs/dash-docs that referenced this pull request Dec 26, 2018
@thephez
V0.13.0 RC updates (#95)
28514b6 
* Content - RPC - Update quick reference

* RPC - Update getblockchaininfo to show BIP-9 progress

Related to dashpay/dash#2435

* RPC - Update gobject prepare with new params

Use-IS (dashpay/dash#2452)
Use specific UTXO for fee (dashpay/dash#2482)

* RPC - Update mode name

* RPC - Update protx default mode

dashpay/dash#2513

* Content - Add spork 17

* Content - Special transactions

Add info for Quorum commitment
Remove messages not in 13.0 (SubTx)

* P2P - Add new txlvote fields

masternodeProTxHash (dashpay/dash#2484)
quorumModifierHash (dashpay/dash#2505)

* RPC - Update protx list

Make all options follow the same parameter format (dashpay/dash#2559)

* Content - version bump

0.13.0.0 bumped to 70213 (dashpay/dash#2557)

* Guide - PrivateSend dstx message limit

Up to 5 simultaneous dstxs per MN allowed (dashpay/dash#2552)

* RPC - Update getblock

Add missing versionHex field (dashpay/dash@e7d9ffa)
Change to use verbosity syntax (dashpay/dash#2506 and
bitcoin/bitcoin#8704)

* P2P - Add qfcommit message (no hexdump example)

DIP6 quorum final commitment (dashpay/dash#2477)

* P2P - qfcommit typo

Change description of llmqType field

* P2P - Special tx payload size clarification

* Guide - Update MN payment description

Related to dashpay/dash#2258

* Guide - fix broken link

* Guide - Update some example txs

Change to hashes on the chain following the 12.3.4 reset

* P2P - Add QcTx hexdump

* P2P - DIP4 message updates

Add SML entry
Update hexdump to include new fields
Add getmnlistd and mnlistdiff to cross ref

* P2P - minor DIP3-related comments
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Jun 29, 2020
@UdjinM6 @CryptoCentric
Unify "protx list" options (dashpay#2559)
df9ce56
@UdjinM6 UdjinM6 deleted the unifyprotxlist branch November 26, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codablock codablock codablock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@UdjinM6 @codablock