Try to fix flaky IX tests in DIP3 tests #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
force-pushed
the
pr_dip3_ix_tests
branch
from
3ae4bb5
to
6264c07
Compare
node0 tends to have many small UTXOs which result in TXs with many inputs and high CPU usage.
codablock
force-pushed
the
pr_dip3_ix_tests
branch
from
6264c07
to
70586ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully fix flaky tests as seen in https://api.travis-ci.org/v3/job/474288097/log.txt
The reason for these tests to fail is that in some situations sending TXs results in more inputs being selected then actually needed, which then overloads the CPU when doing IX. This happens because
SelectCoinsMinConfforces a minimum change ofMIN_CHANGE, which in turn forces adding of more inputs then needed, especially when the spent amount is less thenMIN_CHANGE.This is an issue we should eventually fix in the future, independent from this PR. This PR only tries to increase the sent amount so that in most cases large enough inputs are selected so that one or two of them are enough. The PR also gives more funding to individual nodes.