Fix flaky p2p-fullblocktest #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Announcing as INV results in one GETHEADERS message per INV item with every GETHEADERS containing the same block locator info. This in turn results in many (1088 in p2p-fullblocktests) replies with each having i+1 headers. As every message is sent in one go, the message processing queue gets overloaded, leading to GETDATA timeouts for blocks and thus failing the tests. Announcing the blocks directly with HEADERS avoids all this and results in one GETDATA per announced header. This will later conflict with backported improvements from Bitcoin. When we get to this point, we can simply ignore changes on Dash's side and take the improvements from Bitcoin (which also switch to header announcement, but after some refactorings)
Large reorgs as in the p2p-fullblocktest can cause very long long delays for the ping that we're waiting for. This was not a problem before dashpay#2593, as before this wait_until was waiting forever.
codablock
force-pushed
the
pr_flaky_p2p_fullblocks_tests
branch
from
20d4caf
to
44c4cf8
Compare
UdjinM6
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.