Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LLMQ signing requests/sessions #2634

Merged
merged 16 commits into from
Jan 22, 2019

Conversation

codablock
Copy link

No description provided.

@UdjinM6 UdjinM6 added this to the 14.0 milestone Jan 18, 2019
@codablock codablock force-pushed the pr_llmq_signing branch 5 times, most recently from 6226438 to 1fd9cfa Compare January 21, 2019 06:01
Background threads of the LLMQ system use g_connman, so it should be
initialized before.
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just a couple (code-style) suggestions, otherwise looks good now 👍

src/llmq/quorums_signing.cpp Outdated Show resolved Hide resolved
src/llmq/quorums_signing_shares.cpp Outdated Show resolved Hide resolved
src/llmq/quorums_signing_shares.cpp Outdated Show resolved Hide resolved
src/llmq/quorums_signing_shares.cpp Show resolved Hide resolved
src/llmq/quorums_signing_shares.cpp Outdated Show resolved Hide resolved
src/llmq/quorums_signing_shares.cpp Outdated Show resolved Hide resolved
@codablock
Copy link
Author

Applied suggestions and pushed.

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

utACK

@UdjinM6 UdjinM6 merged commit fdcc765 into dashpay:develop Jan 22, 2019
@UdjinM6 UdjinM6 added RPC Some notable changes to RPC params/behaviour/descriptions P2P Some notable changes on p2p level labels Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2P Some notable changes on p2p level RPC Some notable changes to RPC params/behaviour/descriptions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants