Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't leak skShare in logs #2662

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Don't leak skShare in logs #2662

merged 1 commit into from
Jan 30, 2019

Conversation

codablock
Copy link

Better not take any risks here, even though leaking single skShares is not that bad on its own.

nmarley
nmarley approved these changes Jan 29, 2019
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

PastaPastaPasta
PastaPastaPasta approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 added this to the 14.0 milestone Jan 30, 2019
UdjinM6
UdjinM6 approved these changes Jan 30, 2019
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock codablock merged commit 6fe479a into dashpay:develop Jan 30, 2019
@codablock codablock deleted the pr_llmq_sksharelog branch January 30, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarley nmarley nmarley approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codablock @nmarley @UdjinM6 @PastaPastaPasta