Stop checking MN protocol version before signalling DIP3 #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
approved these changes
Feb 5, 2019
codablock
added a commit
to codablock/dash
that referenced
this pull request
Feb 5, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some internal discussions about the way we let miners signal for DIP3 and it turned out that the threshold of 80% miner support in combination with the requirement to have MNs upgraded at 80% was too conservative.
The purpose of the check for upgraded MNs was introduced to make sure that miners don't signal deployments before enough MNs have upgraded. However, choosing a high value like 80% as a threshold for a deployment in combination with the upgrade check actually requires about 90% of support from miners AND masternodes at the same time, which is not what was intended.
At the moment, we have about 70% of masternodes upgraded to v13, making it safe for miners to signal for every block already. When signalling has reached 80%, we can also assume that upgraded masternodes % will also be higher already.
This PR removes the check for upgraded MNs, allowing miners to signal on every block. The PR will be backport to the v13 branch and released through that branch.