Use smaller (3 out of 5) quorums for regtest/Travis #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 👍 (even though it does a bit more than what the PR description says ;) ) |
| @@ -437,7 +437,7 @@ class CFixedBitSet | |||
| vec[p] = (vBytes[p / 8] & (1 << (p % 8))) != 0; | |||
| if (vBytes.size() * 8 != size) { | |||
| size_t rem = vBytes.size() * 8 - size; | |||
| uint8_t m = (uint8_t)(0xff << rem); | |||
| uint8_t m = ~(uint8_t)(0xff >> rem); | |||
There was a problem hiding this comment.
you like your weird operators ;)
There was a problem hiding this comment.
Not really :D But give me alternatives please :D
The way it was before resulted in nodes 1-3 being unused and 6-8 being used for these 3 special nodes even though these are masternodes.
It's enough to disable networking for this node.
codablock
force-pushed
the
pr_regtest_smaller_quorums
branch
from
6f3041d
to
0c25584
Compare
|
Rebased and force-pushed after merge of #2772 |
|
Tests are finally green 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce the load on Travis quite a bit and thus result in less flaky tests.
Also fixes multiple issues found while fixing tests.