Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix revoke reason check for ProUpRevTx #2787

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Fix revoke reason check for ProUpRevTx #2787

merged 1 commit into from
Mar 21, 2019

Conversation

gladcow
Copy link

@gladcow gladcow commented Mar 20, 2019

CProUpRevTx::REASON_LAST is equal to last valid reason (CProUpRevTx::REASON_CHANGE_OF_KEYS), and that's why it is valid too.

@UdjinM6 UdjinM6 added this to the 14.0 milestone Mar 20, 2019
UdjinM6
UdjinM6 approved these changes Mar 20, 2019
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 added the RPC Some notable changes to RPC params/behaviour/descriptions label Mar 20, 2019
codablock
codablock approved these changes Mar 21, 2019
View reviewed changes
Copy link

@codablock codablock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Also adding the backports label for v13 Udjin was faster :)

@UdjinM6 UdjinM6 merged commit 7135f01 into dashpay:develop Mar 21, 2019
codablock pushed a commit to codablock/dash that referenced this pull request Apr 4, 2019
@codablock
Fix revoke reason check for ProUpRevTx (dashpay#2787)
b52d0ad
@snogcel
Copy link

snogcel commented May 25, 2024

utACK

Might be worth taking a second look at?

@snogcel
Copy link

snogcel commented May 25, 2024

@UdjinM6 https://bitpay.com/insight/BTC/mainnet/block/00000000000000000002b245c489fca7c74d3bad9c772550bbf39f51779972f8 Thank You.

@snogcel
Copy link

snogcel commented May 25, 2024

(......https://classicreload.com/dosx-jones-in-the-fast-lane-cd-rom.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codablock codablock codablock approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
bug RPC Some notable changes to RPC params/behaviour/descriptions
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gladcow @snogcel @codablock @UdjinM6