Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in GetNextMasternodeForPayment #2789

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Fix bug in GetNextMasternodeForPayment #2789

merged 1 commit into from
Mar 21, 2019

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Mar 20, 2019

Fixes #2788

@UdjinM6 UdjinM6 added bug RPC Some notable changes to RPC params/behaviour/descriptions labels Mar 20, 2019
@UdjinM6 UdjinM6 added this to the 14.0 milestone Mar 20, 2019
@thephez
Copy link
Collaborator

thephez commented Mar 21, 2019

Slightly-tested ACK

codablock
codablock approved these changes Mar 21, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock
Copy link

I assume the crash was only happening on develop and not on 0.13.x?

@UdjinM6
Copy link
Author

UdjinM6 commented Mar 21, 2019

@codablock yes, it was introduced recently with the removal of legacy code.

@UdjinM6 UdjinM6 merged commit 0ed5ae0 into dashpay:develop Mar 21, 2019
@UdjinM6 UdjinM6 mentioned this pull request Mar 31, 2019
Closed
@UdjinM6 UdjinM6 deleted the fix2788 branch November 26, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codablock codablock codablock approved these changes

Assignees
No one assigned
Labels
bug RPC Some notable changes to RPC params/behaviour/descriptions
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@UdjinM6 @thephez @codablock