Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential travis failures due to network failures #2795

Merged
merged 3 commits into from
Mar 22, 2019

Conversation

codablock
Copy link

This hopefully fixes many of the spontaneous failures observed on Travis where apt-get or docker pulling fails due to temporary network issues. Example build: https://travis-ci.org/dashpay/dash/jobs/509484783

@codablock
Copy link
Author

The last build for this PR failed with the same apt-get errors I tried to fix with this PR, so it looks like the fix was unsuccessful...

I implemented another approach and force-pushed it. Hopefully this works better now...waiting for builds.

@codablock
Copy link
Author

Last build did not trigger the apt-get failure and thus it's hard to predict if the PR would have fixed it. I would still vote to merge this and then watch Travis for these kinds of failures.

@UdjinM6 UdjinM6 added this to the 14.0 milestone Mar 22, 2019
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock codablock merged commit 3ead8cd into dashpay:develop Mar 22, 2019
@codablock codablock deleted the pr_retryapt branch March 22, 2019 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants