Stop tracking interested/participating nodes and send/announce to MNAUTH peers #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roRegTxHash This makes IsMasternodeQuorumNode return true on incoming peer connections as well.
This makes it return NodeIds for incoming peer connections as well.
This was needed in the past when we were unable to identify incoming connections from other quorum members. Now that we have MNAUTH, we can easily identify all connected members.
Same as with the previous commit, we're now able to easily identify which nodes to announce sig shares to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of MNAUTH we also introduced an optimization to not connect to quorum members when there is already an incoming connection from the same member. This however results in DKGs messages and sig shares not being sent to these nodes. This is also the reason for recent test failures.
This PR makes the DKG and sig shares manager take all MNAUTHed connections into account. This also included incoming connections from other members. At the same time, this removes the need for the tracking of participating/interested nodes, which this PR now also removes.