Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBLSWrapper::SetHexStr() should not accept non-hex strings #2843

Merged
merged 2 commits into from
Apr 8, 2019
Merged

CBLSWrapper::SetHexStr() should not accept non-hex strings #2843

merged 2 commits into from
Apr 8, 2019

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Apr 5, 2019

Fixes the issue mentioned here #2841 (comment)

@UdjinM6 UdjinM6 added this to the 14.0 milestone Apr 5, 2019
nmarley
nmarley previously approved these changes Apr 5, 2019
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

codablock
codablock approved these changes Apr 6, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

codablock
codablock suggested changes Apr 6, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Removed the utACK. Please see inline comment.

src/test/bls_tests.cpp Outdated Show resolved Hide resolved
@nmarley nmarley mentioned this pull request Apr 6, 2019
Merged
codablock
codablock approved these changes Apr 6, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

nmarley
nmarley approved these changes Apr 8, 2019
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 9fa09b9 into dashpay:develop Apr 8, 2019
@UdjinM6 UdjinM6 deleted the fixSetHexStr branch November 26, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarley nmarley nmarley approved these changes

@codablock codablock codablock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@UdjinM6 @nmarley @codablock