Retry locking of child TXs in batches instead of per locked parent #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
force-pushed
the
pr_is_batchedretry
branch
from
b21ac6e
to
56a3fa9
Compare
|
Needs rebase |
codablock
force-pushed
the
pr_is_batchedretry
branch
from
56a3fa9
to
0173582
Compare
|
Rebased |
|
Test failures seem to be unrelated. I'll re-trigger travis |
codablock
force-pushed
the
pr_is_batchedretry
branch
from
0173582
to
54e0dcf
Compare
This especially avoids many calls to ReadBlockFromDisk
codablock
force-pushed
the
pr_is_batchedretry
branch
from
54e0dcf
to
30441e4
Compare
|
One of the test failures was a race condition which is fixed in bitcoin#13192. Backporting this fix is quite hard atm as we're still missing some other backports, so I added a temporary fix which we can later remove when we backport the real fix. The other test failure was in p2p-autoinstantsend.py, which I was not able to tackle down yet. It seems to happen only from time to time. |
codablock
force-pushed
the
pr_is_batchedretry
branch
from
9c69c57
to
30441e4
Compare
|
As discussed in Slack, I'm moving unrelated Travis fixes into its own PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrying immediately when a IS lock came in resulted in many repeated calls to
ReadBlockFromDisk, slowing down and blocking other stuff. This PR changes retrying of locking to batched retries, invoked from the sig shares worker thread.This PR currently includes #2857, which I'll remove later by rebasing.