Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable optimistic send in PushMessage by default #2859

Merged
merged 3 commits into from
Apr 11, 2019
Merged

Disable optimistic send in PushMessage by default #2859

merged 3 commits into from
Apr 11, 2019

Commits on Apr 11, 2019

  1. Automatically wake up select() when optimistic send was not used 

    But only when we know that we are actually inside select() and that it
currenlty is unlikely for it to have selected the node's socket for
sending. We accept race conditions here as the select() timeout
will ensure that we always send the data.
    @codablock
    codablock committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    574adcc View commit details
    Browse the repository at this point in the history

  2. Don't manually call WakeSelect() in CSigSharesManager::SendMessages 

    Not needed anymore
    @codablock
    codablock committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    ef9f254 View commit details
    Browse the repository at this point in the history

  3. Disable optimistic send in PushMessage by default

    @codablock
    codablock committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    828c82a View commit details
    Browse the repository at this point in the history