Use lazy BLS signatures more often and don't always verify self-recovered sigs #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
changed the title
codablock
changed the title
UdjinM6
reviewed
Apr 11, 2019
codablock
force-pushed
the
pr_is_lazysigs
branch
from
f1c87e6
to
2ded0df
Compare
codablock
changed the title
codablock
force-pushed
the
pr_is_lazysigs
branch
from
40c4bf1
to
62e07a4
Compare
codablock
force-pushed
the
pr_is_lazysigs
branch
from
62e07a4
to
2e0b008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid expensive BLS signature deserialization in the message handler thread. The expensive part is implicitly moved into the worker threads now.
This PR also changes how often we verify self-recovered signatures to only 1 out of 100 recoveries. There is actually no need to verify these at all, but sporadically doing so ensures that we catch unexpected bugs.