Accept non-spent LLMQ IS locked outpoints from mempool in PS mixing #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering if this might result in banning nodes due to IS locks being propagated slower then the TXs and nodes which already got both using the TX as input. |
|
@codablock the only node that should care about these IS locks (for mixing inputs/collateral) is the mixing masternode. If it won't have an IS lock for some input sent by one of mixing participants it simply won't accept him as a member of the mixing session, it shouldn't ban him. Also, there is a timeout between mixing sessions on a client so it's highly unlikely (imo) that he would get IS locks and masternode wouldn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.