forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable Automatic Wallet Backup #306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested and works as expected on Mac OS X 10.10.3 Great job! 👍 |
eduffield222
pushed a commit
that referenced
this pull request
Apr 13, 2015
Configurable Automatic Wallet Backup
Great work! |
andvgal
referenced
this pull request
in energicryptocurrency/gen2-energi
Dec 26, 2018
Fixed missing optimization Closes #306 See merge request energi/cryptocurrency/core/energi!298
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Dec 21, 2022
…pay#306) Bumps [engine.io](https://github.com/socketio/engine.io) from 4.1.1 to 4.1.2. - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](https://github.com/socketio/engine.io/blob/4.1.2/CHANGELOG.md) - [Commits](socketio/engine.io@4.1.1...4.1.2) --- updated-dependencies: - dependency-name: engine.io dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://dashtalk.org/threads/v0-11-2-x-testing.4202/page-37#post-50915
I have implemented automatic wallet backups so in case wallet.dat gets corrupted beyond repair the user has the possibility to restore the file from one of the backups.
How it works:
Tests are done under several flavours of Linux, Windows (by yours truly) and OSX (thanks @UdjinM6 👍), and it builds with Gitian without problems.
By default automatic backups are switch ON and set to 10 backups. My reasoning behind this (instead of having it OFF by default):
This is how it looks UI-wise:
![backups](https://cloud.githubusercontent.com/assets/10080039/7105767/9e647fb4-e129-11e4-9e52-0bc341982fbe.png)