Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Allow specifying different cmd-line params for each masternode #3222

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Dec 5, 2019

No description provided.

nmarley
nmarley previously approved these changes Dec 5, 2019
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept ACK, utACK

@codablock
Copy link

codablock commented Dec 5, 2019

concept ACK, but tests are failing...so nACK for now

@UdjinM6
Copy link
Author

UdjinM6 commented Dec 5, 2019

Should be fixed now, let's see...

Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK (tests are succeeding now)

@codablock codablock merged commit 08f447a into dashpay:develop Dec 5, 2019
MIPPL pushed a commit to biblepay/biblepay that referenced this pull request Jan 1, 2020
…ttack vector)

* commit '2ae1ce4800a22c717b67aea97680bbe1eeffa07b':
  [v0.14.0.x] Update release notes with notable changes and changelog (dashpay#3229)
  [v0.14.0.x] Make sure mempool txes are properly processed by CChainLocksHandler despite node restarts (dashpay#3230)
  [v0.14.0.x] Bump version and prepare release notes (dashpay#3228)
  More fixes in llmq-is-retroactive tests
  Make llmq-is-retroactive test compatible with 0.14.0.x
  Make wait_for_xxx methods compatible with 0.14.0.x
  Allow re-signing of IS locks when performing retroactive signing (dashpay#3219)
  Add wait_for_xxx methods as found in develop
  More/better logging for InstantSend
  Tests: Fix the way nodes are connected to each other in setup_network/start_masternodes (dashpay#3221)
  More fixes related to extra_args
  Tests: Allow specifying different cmd-line params for each masternode (dashpay#3222)
  Don't join thread in CQuorum::~CQuorum when called from within the thread (dashpay#3223)
  Merge bitcoin#12392: Fix ignoring tx data requests when fPauseSend is set on a peer (dashpay#3225)

# Conflicts:
#	configure.ac
#	doc/man/biblepay-cli.1
#	doc/man/biblepay-qt.1
#	doc/man/biblepay-tx.1
#	doc/man/biblepayd.1
#	doc/release-notes.md
#	qa/pull-tester/rpc-tests.py
#	qa/rpc-tests/test_framework/test_framework.py
#	src/clientversion.h
barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
@UdjinM6 UdjinM6 deleted the mndifparams branch November 26, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants