Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sum of selected transactions in 'Transactions'-tab #329

Merged
merged 4 commits into from May 14, 2015

Conversation

crowning-
Copy link

References:
http://jira.darkcoin.qa/browse/DRK-138 (JIRA)
https://dashtalk.org/threads/enhanced-darkcoin-wallet-ui.1705/page-22#post-53222 (dashtalk)

Much more convenient than selecting those transactions, export them and compute the sum with an external program.

Looks like this:
amount

Builds fine with Gitian and runs on all 3 OS without problems.

@crowning- crowning- changed the title Show sum of selected transaction in 'Transactions'-tab Show sum of selected transactions in 'Transactions'-tab May 10, 2015
@UdjinM6
Copy link

UdjinM6 commented May 12, 2015

Looks good! 👍
However it works only for shift + mouse click for me (on Mac) and doesn't work for shift + arrow keys and mouse down + mouse move + mouse up Though it's not a big issue but maybe you can fix it too? :)

@crowning-
Copy link
Author

Good point, right now I only send signals to the transaction-list when there's a click event.

I'll have a look later today and report back when it's ready to merge.

@crowning-
Copy link
Author

Adding shift + arrow keys and mouse down + mouse move + mouse up: probably one of the most expensive fixes so far, 8 hours for one line of code.
(actually 1 minute for adding the code, and 479 minutes for figuring out why it doesn't work at the place where I put it and trying one million things to work around the problem )
Facepalm

@evan82 , it's ready to merge.

@UdjinM6
Copy link

UdjinM6 commented May 14, 2015

Everything works fine for me now! Good job! 👍

UdjinM6 added a commit that referenced this pull request May 14, 2015
Show sum of selected transactions in 'Transactions'-tab
@UdjinM6 UdjinM6 merged commit 37e4d80 into dashpay:master May 14, 2015
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 29, 2019
NEW: 'Start Staking' menu item for partial wallet unlock

Closes dashpay#329

See merge request energi/cryptocurrency/core/energi!317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants