Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User configurable Wallet Window Title #401

Merged
merged 3 commits into from Jul 5, 2015
Merged

User configurable Wallet Window Title #401

merged 3 commits into from Jul 5, 2015

Conversation

crowning-
Copy link

Reference: https://dashtalk.org/threads/enhanced-darkcoin-wallet-ui.1705/page-23#post-57474

Funnily enough I also use the "Show Automatic Backups" browser to find out which wallet I'm using...

With -windowtitle=<name> you can now set a dedicated name for each of your wallets.

Looks like this:
walletname

UdjinM6
UdjinM6 reviewed Jul 5, 2015
View reviewed changes
src/init.cpp
@@ -356,6 +356,7 @@ std::string HelpMessage(HelpMessageMode mode)
strUsage += " -upgradewallet " + _("Upgrade wallet to latest format") + " " + _("on startup") + "\n";
strUsage += " -wallet=<file> " + _("Specify wallet file (within data directory)") + " " + strprintf(_("(default: %s)"), "wallet.dat") + "\n";
strUsage += " -walletnotify=<cmd> " + _("Execute command when a wallet transaction changes (%s in cmd is replaced by TxID)") + "\n";
strUsage += " -windowtitle=<name> " + _("Wallet window title") + "\n";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would wrap this in if (mode == HMM_BITCOIN_QT)

@crowning-
Copy link
Author

Both changes done.

@UdjinM6
Copy link

UdjinM6 commented Jul 5, 2015

👍

PS. on a side note: to have our commit history a bit cleaner here is another git tip 😉

  • create feature branch and add commits there

  • once you want to align it with some upstream branch (i.e. v0.12.0.x) fetch it and rebase

    git fetch upstream/v0.12.0.x
git rebase upstream/v0.12.0.x

  • rebase will rewrite your commits on top of upstream so if you pushed your branch to remote repo (github) before rebase you have to force next push with -f (and this will update PR with no issues afaik)

@crowning-
Copy link
Author

Thanks, it already bothered me to have those "Merge remote-tracking branch..." commits showing up all the time. Will try that next time.

@UdjinM6
Copy link

UdjinM6 commented Jul 5, 2015

Yep, no problems, just sharing knowledge 😉

Ok, I hope @evan82 will not complain about these changes so merging it now.

UdjinM6 added a commit that referenced this pull request Jul 5, 2015
@UdjinM6
Merge pull request #401 from crowning-/v0.12.0.x
8d7cce0 
User configurable Wallet Window Title
@UdjinM6 UdjinM6 merged commit 8d7cce0 into dashpay:v0.12.0.x Jul 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crowning- @UdjinM6