Backports v0.18: PR's 14530 and 14365 #4331
Conversation
|
@UdjinM6 Thank you for the proposed change list. I am little bit confused about changes you proposed for bitcoin#14365, My aim is to bring up Python dead code linter. |
|
Yes, my changes enable dead code linter in CI and fix all the issues found by it. |
pravblockc
force-pushed
the
backports-v0.18-pr10
branch
from
3e7efd5
to
1ee4084
Compare
Thank you, all changes were brought in now, please review |
|
This pull request has conflicts, please rebase. |
pravblockc
force-pushed
the
backports-v0.18-pr10
branch
from
1ee4084
to
19e8d96
Compare
fa483e1 rpc: Add RPCHelpMan for machine-generated help (MarcoFalke) fa0d36f rpc: Include rpc/util.h where needed for RPCHelpMan (MarcoFalke) Pull request description: This introduces a manager for the RPC help generation and demonstrates its use of it in some RPCs. It is the first non-exhaustive step toward bitcoin#14378 and I will create pull requests for the next steps after this one is merged. Tree-SHA512: 86f68322443ff01cd964aaf0ebe186be63fbebe4c47676cf7a622cc2b5305fd176bd57badfd1bbf788a036812253eb0dead74ecc3b30664c3e0d9392b2248054
…Travis c82190c tests: Add Python dead code linter (vulture) (practicalswift) 590a57f tests: Remove unused testing code (practicalswift) Pull request description: Add Python dead code linter (`vulture`) to Travis. Rationale for allowing dead code only after explicit opt-in (via `--ignore-names`): * Less is more :-) * Unused code is by definition "untested" * Unused code can be an indication of bugs/logical errors. By making the contributor aware of newly introduced unused code it gives him/her an opportunity to investigate if the unused code they introduce is malignant or benign :-) * Unused code is hard to spot for humans and is thus often missed during manual review * [YAGNI](https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it) Based on bitcoin#14312 to make linter job pass. Tree-SHA512: 4c581df7c34986e226e4ade479e0d3c549daf38f4a4dc4564b25564d63e773a1830ba55d1289c771b1fa325483e8855b82b56e61859fe8e4b7dfa54034b093b6
pravblockc
force-pushed
the
backports-v0.18-pr10
branch
from
19e8d96
to
12047d7
Compare
| { | ||
| {"changeAddress", RPCArg::Type::STR_HEX, true}, | ||
| {"changePosition", RPCArg::Type::NUM, true}, | ||
| {"change_type", RPCArg::Type::STR, true}, |
There was a problem hiding this comment.
I feel like this parameter has been added here by mistake and is not really used by Dash.
@kittywhiskers can you comment? If so, I'll remove it in my next PR as I deal with this code there.
There was a problem hiding this comment.
Correct, this looks like a mistake, please correct :) (preferably in it's own PR)
Backports v0.18: PR's 14530 and 14365