Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: implement predict-conflicts actions #4645

Merged
merged 2 commits into from
Dec 30, 2021

Conversation

PastaPastaPasta
Copy link
Member

This action will comment on a PR, if there is another PR that changes the same file that it changes.

See PastaPastaPasta#25 and PastaPastaPasta#26 (opened at basically the same time). As these conflict, they both get comments linking to the other PR.

Then PastaPastaPasta#27 was opened a minute or two later. This PR triggers another comment on 25 and 26 as there is now an additional PR they may conflict with, and a comment gets placed on itself.

Then PastaPastaPasta#28 was opened, but since it didn't potentially conflict with any other PRs, no comments were generated

This will be quite useful to prioritize merging between different PRs and avoiding very annoying git conflict resolutions.

@PastaPastaPasta PastaPastaPasta added this to the 18 milestone Dec 29, 2021
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 58b2605 into dashpay:develop Dec 30, 2021
@UdjinM6
Copy link

UdjinM6 commented Dec 30, 2021

@PastaPastaPasta
Copy link
Member Author

It's broken it seems, pls see https://github.com/dashpay/dash/runs/4668473677?check_suite_focus=true

see #4647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants