refactor: Refactor CalcCbTxMerkleRootQuorums
#4954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please rebase. |
UdjinM6
force-pushed
the
add_cbq_cache_refactor
branch
from
bfa9ea4
to
5a8e060
Compare
UdjinM6
force-pushed
the
add_cbq_cache_refactor
branch
2 times, most recently
from
f88dfa3
to
347ce3e
Compare
|
This pull request has conflicts, please rebase. |
UdjinM6
force-pushed
the
add_cbq_cache_refactor
branch
from
347ce3e
to
1127dcd
Compare
PastaPastaPasta
previously approved these changes
Aug 11, 2022
PastaPastaPasta
changed the title
CalcCbTxMerkleRootQuorumsCalcCbTxMerkleRootQuorums
Ofc it's not 0 when cache is used... not sure what I was thinking about.
|
I messed up (818886a) 🙈 pls re-review |
PastaPastaPasta
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking suggestions from #4952 (comment), applying few cleanups and doing some trivial-ish refactoring on top. Also moved few things including
IsQuorumRotationEnabledout of the inner loop - should not result in any changes in behaviour, could simply be a tiny bit faster.builds on top of #4952