fix!: Rotation members calc v19 #5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@UdjinM6 In order to avoid a chain re-organisation (again) in Testnet, we can simply do that. (Idea of @PastaPastaPasta ) |
PastaPastaPasta
approved these changes
Jan 10, 2023
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 12, 2023
With 18.2, block `0000000000000044356e582f9748f9baf084e5b7946e6386b32620d540830fda` is marked invalid with `bad-qc-invalid`. ## Issue being fixed or feature implemented While the 19 isn’t active -> Calculate rotation members based on 18.1 code Once 19 active -> Calculate rotation members based on 18.2 code ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation **For repository code-owners and collaborators only** - [x] I have assigned this pull request to a milestone
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 12, 2023
With 18.2, block `0000000000000044356e582f9748f9baf084e5b7946e6386b32620d540830fda` is marked invalid with `bad-qc-invalid`. ## Issue being fixed or feature implemented While the 19 isn’t active -> Calculate rotation members based on 18.1 code Once 19 active -> Calculate rotation members based on 18.2 code ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation **For repository code-owners and collaborators only** - [x] I have assigned this pull request to a milestone
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jan 12, 2023
With 18.2, block `0000000000000044356e582f9748f9baf084e5b7946e6386b32620d540830fda` is marked invalid with `bad-qc-invalid`. ## Issue being fixed or feature implemented While the 19 isn’t active -> Calculate rotation members based on 18.1 code Once 19 active -> Calculate rotation members based on 18.2 code ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation **For repository code-owners and collaborators only** - [x] I have assigned this pull request to a milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 18.2, block
0000000000000044356e582f9748f9baf084e5b7946e6386b32620d540830fdais marked invalid withbad-qc-invalid.Issue being fixed or feature implemented
While the 19 isn’t active -> Calculate rotation members based on 18.1 code
Once 19 active -> Calculate rotation members based on 18.2 code
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only