feat(rpc): protx listdiff rpc #5338

ogabrielides · 2023-04-18T15:17:51Z

Issue being fixed or feature implemented

Feature requested by @QuantumExplorer and @iammadab.
This PR introduces protx listdiff: a more rich alternative of protx diff RPC.

Currently, protx diff is returning data only required from SPV for SML Coinbase MerkleMNListRoot calculation.

Platform team needed a similar RPC returning all the MNs data in order to calculate the identities.

Go over all the following points, and put an x in all the boxes that apply.

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

UdjinM6 · 2023-04-18T22:10:34Z

looks good but would be nice to have some tests

PastaPastaPasta

utACK for squash merge; platform needs this to continue testing, so let's just merge w/o tests and hopefully come back to the tests

ogabrielides marked this pull request as draft April 18, 2023 15:18

ogabrielides added the RPC Some notable changes to RPC params/behaviour/descriptions label Apr 18, 2023

ogabrielides added this to the 20 milestone Apr 18, 2023

ogabrielides requested review from UdjinM6, PastaPastaPasta and QuantumExplorer April 18, 2023 15:26

ogabrielides marked this pull request as ready for review April 18, 2023 15:27

ogabrielides added 3 commits April 18, 2023 23:17

protx listdiff rpc

92576b2

Create release-notes-5338.md

f3e2915

linter fix

4af77e4

UdjinM6 force-pushed the protx_listdiff_rpc branch from 1ffd554 to 4af77e4 Compare April 18, 2023 20:17

PastaPastaPasta approved these changes Apr 19, 2023

View reviewed changes

PastaPastaPasta merged commit 6499917 into dashpay:develop Apr 19, 2023

ogabrielides deleted the protx_listdiff_rpc branch April 19, 2023 14:52