Revert 25a07f10 -- makefile.unix #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STATIC=1 not cleanly implemented
eduffield222
pushed a commit
that referenced
this pull request
Dec 5, 2014
Revert 25a07f1 -- makefile.unix
|
opps, thanks |
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jul 17, 2019
* Bump version on pacmn.sh and pac-update.sh to v12.5.1
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
[bug][snap][gitian][build][artworks] Fix wrong demo address in preparebudget and change proposal icon
FornaxA
added a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
Update release notes and rpc documentation Approved-by: Cevap
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Dec 21, 2022
…pay#56) Conversion like "std::string(b)" result in a temporary r value with a short/undefined lifetime. Accessing data of it via pointers into internal data gives undefined behavior. The fix is to use a temporary variable which has a well defined lifetime. The issue that is fixed here is that even when "from_xxx" methods were called with the same data, the resulting keys were different each time. I assume this was not noticed before as it only appear to happen with some compiler versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STATIC=1 not cleanly implemented