Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set release version to true; set rc to 0 #5695

Merged
merged 1 commit into from
Nov 14, 2023
Merged

chore: set release version to true; set rc to 0 #5695

merged 1 commit into from
Nov 14, 2023

Conversation

PastaPastaPasta
Copy link
Member

Issue being fixed or feature implemented

Bump release to true; rc to 0

This should be the final PR merged to v20.x branch

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@PastaPastaPasta PastaPastaPasta added this to the 20 milestone Nov 13, 2023
ogabrielides
ogabrielides approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta mentioned this pull request Nov 13, 2023
Open
47 tasks
knst
knst approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

UdjinM6
UdjinM6 approved these changes Nov 14, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta merged commit df79078 into dashpay:v20.x Nov 14, 2023
6 of 7 checks passed
@PastaPastaPasta PastaPastaPasta deleted the v20-set-release-true branch November 14, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielides ogabrielides ogabrielides approved these changes

@knst knst knst approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PastaPastaPasta @ogabrielides @knst @UdjinM6