Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qt): tab switching via shortcuts doesn't work after 5986 #5995

Merged
1 commit merged into from
Apr 26, 2024

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Apr 24, 2024

Issue being fixed or feature implemented

Looks like 3265b54 (#5986) broke it

What was done?

How Has This Been Tested?

run dash-qt, try using shortcuts cmd+1, cmd+2 etc. (on macos)

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 21 milestone Apr 24, 2024
@UdjinM6 UdjinM6 changed the title fix(qt): tab switching via Ctrl+<N> doesn't work after 5986 fix(qt): tab switching via shortcuts doesn't work after 5986 Apr 24, 2024
@UdjinM6 UdjinM6 force-pushed the fix_updateButtonGroupShortcuts branch from 419c6df to c874205 Compare April 24, 2024 12:07
@PastaPastaPasta
Copy link
Member

Whoops he had asked me to test that 🙈

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c874205

Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ubuntu 20.04, works fine

ACK c874205

@PastaPastaPasta PastaPastaPasta closed this pull request by merging all changes into dashpay:develop in b1852e0 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants