feat: Let addrman handle multiple ports for all networks #6062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
There is really no need to do have this restriction in
addrman
, we checkAllowMultiplePorts()
inconnman
which should be enough already. We can safely re-alignaddrman
to its upstream implementation as suggested in #6043.What was done?
Drop port "discrimination" in
addrman
, remove related tests.How Has This Been Tested?
Run tests, run dash-qt on mainnet/testnet
Breaking Changes
n/a
Checklist: