-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make a support of Qt app to show Platform transfer Tx #6131
base: develop
Are you sure you want to change the base?
Conversation
fbd50cf
to
b9118f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b9118f5 looks incomplete - you just import a key but you don't check any tx/rpc
The term |
Could you suggest? just "Asset unlock" is not good too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General NACK for v21.0; we are in feature freeze and releasing in 9 days. We need to avoid new features at all costs. We can include this in a fast following 21.1
Yes, we should think about this. I agree with @kxcd. It will be confusing because it is not a withdrawal from the wallet's perspective - it's an incoming tx just like a masternode reward, incoming payment, etc. Maybe something like |
Thanks Phez, I like |
b9118f5
to
70cbef9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 70cbef9 (mac-build CI failure is unrelated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general NACK on "withdrawal" terminology. Want utACK from @thephez / suggestions
current version has mentioning of |
Maybe add information about what the terms are then in description? |
@@ -408,6 +408,7 @@ struct WalletTx | |||
int64_t time; | |||
std::map<std::string, std::string> value_map; | |||
bool is_coinbase; | |||
bool is_platform_transfer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know none of the others do it, but we should ensure these are always initialized
bool is_platform_transfer; | |
bool is_platform_transfer{false}; |
Issue being fixed or feature implemented
Transfers from platform have incorrectly shown amount in Dash Core wallet app.
They also shown in Qt app as self-send that is not completely true.
What was done?
Added new type of transaction to Qt App, added a filter for its type, fixed calculation of output for tx records.
As well added a new type of transaction
platform-transfer
in rpc output ofgettransaction
RPCHow Has This Been Tested?
Make a withdrawal transaction on RegTest and check it in Dash Core
Helper to see it: export dpath=/tmp/dash_func_test_PATHPATH/ ; src/qt/dash-qt -regtest -conf=$dpath/node0/dash.conf -datadir=$dpath/node0/ -debug=0 -debuglogfile=/dev/stdout
Breaking Changes
There's new type of transaction "platform-transfer" in rpc output of
gettransaction
.This PR DOES NOT change any consensus rules.
Breaking changes that makes withdrawal transaction immature is moved to #6128
Checklist: