Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare v20 branch for release #238

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

  • support building on Mac
  • adjust protocol and set v20 block height

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@HashEngineering HashEngineering self-assigned this Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (6b91b05) 48.01% compared to head (50ea365) 48.01%.
Report is 1 commits behind head on feature-core-20.

Files Patch % Lines
...c/main/java/org/bitcoin/paymentchannel/Protos.java 8.33% 11 Missing ⚠️
core/src/main/java/org/bitcoinj/wallet/Protos.java 70.27% 11 Missing ⚠️
...a/org/bitcoinj/protocols/channels/ClientState.java 0.00% 7 Missing ⚠️
.../main/java/org/bitcoin/crawler/PeerSeedProtos.java 0.00% 5 Missing ⚠️
...a/org/bitcoinj/protocols/channels/ServerState.java 0.00% 5 Missing ⚠️
...in/java/org/bitcoin/protocols/payments/Protos.java 87.50% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             feature-core-20     #238   +/-   ##
==================================================
  Coverage              48.01%   48.01%           
  Complexity              6665     6665           
==================================================
  Files                    409      409           
  Lines                  46109    46110    +1     
  Branches                6502     6502           
==================================================
+ Hits                   22137    22141    +4     
+ Misses                 21565    21562    -3     
  Partials                2407     2407           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HashEngineering HashEngineering merged commit 3da9f7a into feature-core-20 Dec 7, 2023
6 checks passed
@HashEngineering HashEngineering deleted the feature-core-20-release branch January 10, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants