chore(dashpay): restoring Contacts flow #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syn-McJ
commented
Aug 5, 2023
| @@ -24,7 +24,6 @@ extern NSNotificationName const DWDashPayAvailabilityStatusUpdatedNotification; | |||
| @protocol DWDashPayReadyProtocol <NSObject> | |||
|
|
|||
| @property (readonly, nonatomic, assign) BOOL isDashPayReady; | |||
| @property (readonly, nonatomic, assign) BOOL isDashPayReadyMainSuggestion; | |||
There was a problem hiding this comment.
Not needed atm. Removed to keep the DWDashPayReadyProtocol footprint low.
| @@ -42,7 +43,7 @@ NS_ASSUME_NONNULL_BEGIN | |||
| - (void)homeModelWantToReloadShortcuts:(id<DWHomeProtocol>)model; | |||
| @end | |||
|
|
|||
| @protocol DWHomeProtocol <DWTxDisplayModeProtocol> | |||
| @protocol DWHomeProtocol <DWTxDisplayModeProtocol, DWDashPayReadyProtocol> | |||
There was a problem hiding this comment.
Contacts VC requires DWDashPayReadyProtocol which was implemented by the home model before. Perhaps there is a path to refactor this in the future stories.
Syn-McJ
commented
Aug 7, 2023
| @@ -24,5 +24,6 @@ | |||
|
|
|||
| NSInteger DW_MIN_USERNAME_LENGTH = 3; | |||
| NSInteger DW_MAX_USERNAME_LENGTH = 24; | |||
| BOOL MOCK_DASHPAY = YES; // TODO: remove once Platform is available | |||
There was a problem hiding this comment.
I figure it's better to reference a single flag for any mocking code. Will be easier to turn off and remove once the platform is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
As a part of the "Bringing back DashPay" initiative, the contacts entry point in the tabbar should be restored.
What was done?
dashPayModelto sync with theHomeHeaderViewHow Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only