-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dashpay): restoring Contacts flow #584
Merged
tikhop
merged 8 commits into
dashpay:feature/dashpay
from
Syn-McJ:feature/dashpay-contacts-flow
Aug 8, 2023
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
48a0964
fix: DWTxDetailModel name
Syn-McJ 16d6ef1
feat: Contacts and Explore in the main tabbar
Syn-McJ 3924f4c
feat: tabbar icons
Syn-McJ 39c957b
feat: explore events handling
Syn-McJ 7d6068d
chore: username mocking
Syn-McJ c698a34
feat: username search mocking
Syn-McJ 421cd9f
Merge branch 'feature/dashpay-contacts-search' into feature/dashpay-c…
Syn-McJ fb6d609
fix: wallet build fix
Syn-McJ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
6 changes: 3 additions & 3 deletions
6
.../tabbar_pay_button.imageset/Contents.json → ...bbar_contacts_icon.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+677 Bytes
.../Resources/AppAssets.xcassets/TabBar/tabbar_contacts_icon.imageset/contacts.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.18 KB
...sources/AppAssets.xcassets/TabBar/tabbar_contacts_icon.imageset/contacts@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.62 KB
...sources/AppAssets.xcassets/TabBar/tabbar_contacts_icon.imageset/contacts@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions
6
...bbar_discover_icon.imageset/Contents.json → ..._contacts_selected.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+662 Bytes
...pAssets.xcassets/TabBar/tabbar_contacts_selected.imageset/contacts_selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.1 KB
...sets.xcassets/TabBar/tabbar_contacts_selected.imageset/contacts_selected@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.57 KB
...sets.xcassets/TabBar/tabbar_contacts_selected.imageset/contacts_selected@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 6 additions & 6 deletions
12
...bbar_contacts_icon.imageset/Contents.json → ...bbar_discover_icon.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "explore.png", | ||
"idiom" : "universal", | ||
"filename" : "tabbar_contacts_icon.png", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "explore@2x.png", | ||
"idiom" : "universal", | ||
"filename" : "tabbar_contacts_icon@2x.png", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "explore@3x.png", | ||
"idiom" : "universal", | ||
"filename" : "tabbar_contacts_icon@3x.png", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"version" : 1, | ||
"author" : "xcode" | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} | ||
} |
Binary file added
BIN
+614 Bytes
...t/Resources/AppAssets.xcassets/TabBar/tabbar_discover_icon.imageset/explore.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.11 KB
...esources/AppAssets.xcassets/TabBar/tabbar_discover_icon.imageset/explore@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.57 KB
...esources/AppAssets.xcassets/TabBar/tabbar_discover_icon.imageset/explore@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions
23
...allet/Resources/AppAssets.xcassets/TabBar/tabbar_discover_selected.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "explore_selected.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "explore_selected@2x.png", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "explore_selected@3x.png", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Binary file added
BIN
+1.77 KB
...ppAssets.xcassets/TabBar/tabbar_discover_selected.imageset/explore_selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.15 KB
...ssets.xcassets/TabBar/tabbar_discover_selected.imageset/explore_selected@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.74 KB
...ssets.xcassets/TabBar/tabbar_discover_selected.imageset/explore_selected@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 6 additions & 6 deletions
12
...s/tabbar_home_icon.imageset/Contents.json → ...r/tabbar_home_icon.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,26 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "home.png", | ||
"idiom" : "universal", | ||
"filename" : "tabbar_home_icon.png", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "home@2x.png", | ||
"idiom" : "universal", | ||
"filename" : "tabbar_home_icon@2x.png", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "home@3x.png", | ||
"idiom" : "universal", | ||
"filename" : "tabbar_home_icon@3x.png", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"version" : 1, | ||
"author" : "xcode" | ||
"author" : "xcode", | ||
"version" : 1 | ||
}, | ||
"properties" : { | ||
"template-rendering-intent" : "template" | ||
} | ||
} | ||
} |
Binary file added
BIN
+407 Bytes
DashWallet/Resources/AppAssets.xcassets/TabBar/tabbar_home_icon.imageset/home.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+722 Bytes
...allet/Resources/AppAssets.xcassets/TabBar/tabbar_home_icon.imageset/home@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+907 Bytes
...allet/Resources/AppAssets.xcassets/TabBar/tabbar_home_icon.imageset/home@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions
23
DashWallet/Resources/AppAssets.xcassets/TabBar/tabbar_home_selected.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "home_selected.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "home_selected@2x.png", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "home_selected@3x.png", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Binary file added
BIN
+409 Bytes
...urces/AppAssets.xcassets/TabBar/tabbar_home_selected.imageset/home_selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+625 Bytes
...es/AppAssets.xcassets/TabBar/tabbar_home_selected.imageset/home_selected@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+884 Bytes
...es/AppAssets.xcassets/TabBar/tabbar_home_selected.imageset/home_selected@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 6 additions & 6 deletions
12
.../tabbar_other_icon.imageset/Contents.json → .../tabbar_other_icon.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,26 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "more.png", | ||
"idiom" : "universal", | ||
"filename" : "tabbar_other_icon.png", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "more@2x.png", | ||
"idiom" : "universal", | ||
"filename" : "tabbar_other_icon@2x.png", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "more@3x.png", | ||
"idiom" : "universal", | ||
"filename" : "tabbar_other_icon@3x.png", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"version" : 1, | ||
"author" : "xcode" | ||
"author" : "xcode", | ||
"version" : 1 | ||
}, | ||
"properties" : { | ||
"template-rendering-intent" : "template" | ||
} | ||
} | ||
} |
Binary file added
BIN
+340 Bytes
DashWallet/Resources/AppAssets.xcassets/TabBar/tabbar_other_icon.imageset/more.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+551 Bytes
...llet/Resources/AppAssets.xcassets/TabBar/tabbar_other_icon.imageset/more@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+810 Bytes
...llet/Resources/AppAssets.xcassets/TabBar/tabbar_other_icon.imageset/more@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions
23
DashWallet/Resources/AppAssets.xcassets/TabBar/tabbar_other_selected.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "more_selected.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "more_selected@2x.png", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "more_selected@3x.png", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Binary file added
BIN
+337 Bytes
...rces/AppAssets.xcassets/TabBar/tabbar_other_selected.imageset/more_selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+527 Bytes
...s/AppAssets.xcassets/TabBar/tabbar_other_selected.imageset/more_selected@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+772 Bytes
...s/AppAssets.xcassets/TabBar/tabbar_other_selected.imageset/more_selected@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions
23
DashWallet/Resources/AppAssets.xcassets/TabBar/tabbar_pay_button.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "receive.sent.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "receive.sent@2x.png", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "receive.sent@3x.png", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Binary file added
BIN
+312 Bytes
...Resources/AppAssets.xcassets/TabBar/tabbar_pay_button.imageset/receive.sent.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+443 Bytes
...ources/AppAssets.xcassets/TabBar/tabbar_pay_button.imageset/receive.sent@2x.png
Oops, something went wrong.
Binary file added
BIN
+613 Bytes
...ources/AppAssets.xcassets/TabBar/tabbar_pay_button.imageset/receive.sent@3x.png
Oops, something went wrong.
Binary file removed
BIN
-588 Bytes
...urces/AppAssets.xcassets/tabbar_contacts_icon.imageset/tabbar_contacts_icon.png
Diff not rendered.
Binary file removed
BIN
-1.06 KB
...es/AppAssets.xcassets/tabbar_contacts_icon.imageset/tabbar_contacts_icon@2x.png
Diff not rendered.
Binary file removed
BIN
-1.51 KB
...es/AppAssets.xcassets/tabbar_contacts_icon.imageset/tabbar_contacts_icon@3x.png
Diff not rendered.
Binary file removed
BIN
-972 Bytes
...urces/AppAssets.xcassets/tabbar_discover_icon.imageset/tabbar_discover_icon.png
Diff not rendered.
Binary file removed
BIN
-1.91 KB
...es/AppAssets.xcassets/tabbar_discover_icon.imageset/tabbar_discover_icon@2x.png
Diff not rendered.
Binary file removed
BIN
-3.05 KB
...es/AppAssets.xcassets/tabbar_discover_icon.imageset/tabbar_discover_icon@3x.png
Diff not rendered.
Binary file removed
BIN
-335 Bytes
...let/Resources/AppAssets.xcassets/tabbar_home_icon.imageset/tabbar_home_icon.png
Diff not rendered.
Binary file removed
BIN
-590 Bytes
.../Resources/AppAssets.xcassets/tabbar_home_icon.imageset/tabbar_home_icon@2x.png
Diff not rendered.
Binary file removed
BIN
-920 Bytes
.../Resources/AppAssets.xcassets/tabbar_home_icon.imageset/tabbar_home_icon@3x.png
Diff not rendered.
Binary file removed
BIN
-271 Bytes
...t/Resources/AppAssets.xcassets/tabbar_other_icon.imageset/tabbar_other_icon.png
Diff not rendered.
Binary file removed
BIN
-509 Bytes
...esources/AppAssets.xcassets/tabbar_other_icon.imageset/tabbar_other_icon@2x.png
Diff not rendered.
Binary file removed
BIN
-783 Bytes
...esources/AppAssets.xcassets/tabbar_other_icon.imageset/tabbar_other_icon@3x.png
Diff not rendered.
Binary file removed
BIN
-550 Bytes
...t/Resources/AppAssets.xcassets/tabbar_pay_button.imageset/tabbar_pay_button.png
Diff not rendered.
Binary file removed
BIN
-822 Bytes
...esources/AppAssets.xcassets/tabbar_pay_button.imageset/tabbar_pay_button@2x.png
Diff not rendered.
Binary file removed
BIN
-1.05 KB
...esources/AppAssets.xcassets/tabbar_pay_button.imageset/tabbar_pay_button@3x.png
Diff not rendered.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,5 +24,6 @@ | |
|
||
NSInteger DW_MIN_USERNAME_LENGTH = 3; | ||
NSInteger DW_MAX_USERNAME_LENGTH = 24; | ||
BOOL MOCK_DASHPAY = YES; // TODO: remove once Platform is available | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I figure it's better to reference a single flag for any mocking code. Will be easier to turn off and remove once the platform is available. |
||
|
||
NSString *const DWDP_THUMBNAIL_SERVER = @"http://54.74.4.114"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed atm. Removed to keep the
DWDashPayReadyProtocol
footprint low.