-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document the dash analogue of BIP143 #149
Open
panleone
wants to merge
10
commits into
dashpay:master
Choose a base branch
from
panleoneDash:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thephez
requested review from
ogabrielides,
knst,
UdjinM6 and
PastaPastaPasta
February 7, 2024 14:03
UdjinM6
reviewed
Feb 7, 2024
knst
reviewed
Feb 7, 2024
5 tasks
Reviews applied and updated the test to make it consistent with the new approach |
thephez
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this! I've added a few suggestions.
thanks for the review, I have applied your suggestions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to the old PR #95
This PR describes how the transaction sighash algorithm of BIP143 can be adapted to dash. There are only 2 main differences:
nType
andvExtraPayload
nVersion = 4
and it's deployed with an ehf hard fork.The example in the test section was created with a draft implementation of the algorithm (see dashpay/dash#5860)