Update p2pool-dash for working with DashCore v0.12.1.x #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Try use getblocktemplate first - Fix case no transaction. - Fix case no votes found from getblocktemplate (Removed by dashpay/dash@e2aaf09 )
Added missing label to current_payouts table
interface for NxtChg to assist with http://cryptoplay.net/vote.
…rt_networks
If you're having trouble merging this commit, first merge this commit's parent, and then
start merging this commit and do this to apply what this commit does to your networks:
git reset HEAD . # reset index to your copy
git checkout HEAD . # reset tree to your copy
rm -fr p2pool/networks p2pool/dash/networks # remove added files
dev/convert_networks # convert networks to new format (what this commit does)
git commit # finish the merge
Conflicts: p2pool/main.py p2pool/web.py
Conflicts: p2pool/p2p.py
* Update setup.py * Create appveyor.yml
…to add or remove transactions to known_txs_var and trigger callbacks (for caching) on just the changes, instead of triggering a callback on the before and after state. This should improve performance dramatically with large mempools when receiving or removing transactions. Conflicts: p2pool/node.py p2pool/p2p.py
|
BTW, p2pool-dash seed nodes possibly need to update, suggestions are welcome. |
This was referenced Jan 31, 2017
* Check Version to 120100 * Update bootstrap addr for mainnet *
UdjinM6
requested changes
Feb 7, 2017
p2pool/dash/helper.py
Outdated
| @@ -14,12 +14,12 @@ def check(dashd, net): | |||
| print >>sys.stderr, " Check failed! Make sure that you're connected to the right dashd with --dashd-rpc-port!" | |||
| raise deferral.RetrySilentlyException() | |||
| if not net.VERSION_CHECK((yield dashd.rpc_getinfo())['version']): | |||
| print >>sys.stderr, ' dash version too old! Upgrade to 0.11.2.17 or newer!' | |||
| print >>sys.stderr, ' dash version too old! Upgrade to 0.12.0.58 or newer!' | |||
p2pool/dash/p2p.py
Outdated
| @@ -19,7 +19,7 @@ def __init__(self, net): | |||
|
|
|||
| def connectionMade(self): | |||
| self.send_version( | |||
| version=70077, | |||
| version=70204, | |||
|
Tested on testnet , I'm running a mainnet node (p2pool.dash.siampm.com), we still need to get in touch with other pools to update seed nodes. |
|
Another user confirmed successful node start with this code https://www.dash.org/forum/threads/p2pool-repository-and-python-modules-may-2016.8795/#post-113168 Probably ok to merge. @schinzelh ? |
|
Post-merge update:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if we need to add anything.
Possibly version bump to compatible with DashCore release.