-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: wasm-dpp integration #848
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
…feat/wasm-dpp-integration
…rm into feat/wasm-dpp-integration
…rm into feat/wasm-dpp-integration
…feat/wasm-dpp-integration
…rm into feat/wasm-dpp-integration
…feat/wasm-dpp-integration
…rm into feat/wasm-dpp-integration
…rm into feat/wasm-dpp-integration
…tract_update_transition_factory.rs call
…rm into feat/wasm-dpp-integration
…feat/wasm-dpp-integration
# Conflicts: # .pnp.cjs # packages/js-drive/test/unit/dpp/DriveStateRepository.spec.js # packages/rs-drive-nodejs/package.json # packages/wallet-lib/package.json # packages/wasm-dpp/package.json # yarn.lock
Co-authored-by: strophy <badfunkstripe@gmail.com>
shumkov
reviewed
Apr 17, 2023
…feat/wasm-dpp-integration
shumkov
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
markin-io
added a commit
that referenced
this pull request
Apr 26, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru> Co-authored-by: shuplenkov <konstantin.shuplenkov@dash.org> Co-authored-by: Djavid Gabibiyan <djavidoff@gmail.com> Co-authored-by: Anton Suprunchuk <anton.suprunchuk@gmail.com>
markin-io
added a commit
that referenced
this pull request
Apr 27, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru> Co-authored-by: shuplenkov <konstantin.shuplenkov@dash.org> Co-authored-by: Djavid Gabibiyan <djavidoff@gmail.com> Co-authored-by: Anton Suprunchuk <anton.suprunchuk@gmail.com>
markin-io
added a commit
that referenced
this pull request
Apr 27, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru> Co-authored-by: shuplenkov <konstantin.shuplenkov@dash.org> Co-authored-by: Djavid Gabibiyan <djavidoff@gmail.com> Co-authored-by: Anton Suprunchuk <anton.suprunchuk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Integrate WASM DPP to Platform instead JS DPP.
What was done?
js-dpp
withwasm-dpp
across the whole system. (Some non-essential usages ofjs-dpp
such as constants are still present, but mostly in tests)Projects affected directly:
How Has This Been Tested?
Breaking Changes
Some wasm-dpp APIs are different to js-dpp ones. The only divergencies that were addressed are the ones that were visible in tests, but some others might've been left intact
Checklist:
For repository code-owners and collaborators only