Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: wasm-dpp integration #848

Merged
merged 427 commits into from
Apr 18, 2023
Merged

feat!: wasm-dpp integration #848

merged 427 commits into from
Apr 18, 2023

Conversation

markin-io
Copy link
Contributor

@markin-io markin-io commented Mar 22, 2023

Issue being fixed or feature implemented

Integrate WASM DPP to Platform instead JS DPP.

What was done?

  • Replaced js-dpp with wasm-dpp across the whole system. (Some non-essential usages of js-dpp such as constants are still present, but mostly in tests)
  • Updated build system to build wasm-dpp for dependent projects
  • Fixed many issues in different components including:
    • Invalid format and regexp in system contracts
    • self-hosted runner and comprehensive caching for CI
    • deterministic instant lock for local network
    • Identifiers in document queries

Projects affected directly:

  • sdk
  • wallet-lib
  • dapi-client
  • dapi
  • js-drive
  • rs-drive-nodejs
  • platform-test-suite

How Has This Been Tested?

  • Platform test suite
  • Platform tutorials
  • Unit, functional and integration tests in affected projects
  • Devnet deployment and testing
  • CI checks

Breaking Changes

Some wasm-dpp APIs are different to js-dpp ones. The only divergencies that were addressed are the ones that were visible in tests, but some others might've been left intact

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

shumkov and others added 29 commits April 4, 2023 18:03
antouhou and others added 9 commits April 17, 2023 15:03
# Conflicts:
#	.pnp.cjs
#	packages/js-drive/test/unit/dpp/DriveStateRepository.spec.js
#	packages/rs-drive-nodejs/package.json
#	packages/wallet-lib/package.json
#	packages/wasm-dpp/package.json
#	yarn.lock
Co-authored-by: strophy <badfunkstripe@gmail.com>
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 8d56066 into v0.24-dev Apr 18, 2023
@shumkov shumkov deleted the feat/wasm-dpp-integration branch April 18, 2023 12:58
markin-io added a commit that referenced this pull request Apr 26, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Co-authored-by: shuplenkov <konstantin.shuplenkov@dash.org>
Co-authored-by: Djavid Gabibiyan <djavidoff@gmail.com>
Co-authored-by: Anton Suprunchuk <anton.suprunchuk@gmail.com>
@markin-io markin-io mentioned this pull request Apr 26, 2023
5 tasks
markin-io added a commit that referenced this pull request Apr 27, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Co-authored-by: shuplenkov <konstantin.shuplenkov@dash.org>
Co-authored-by: Djavid Gabibiyan <djavidoff@gmail.com>
Co-authored-by: Anton Suprunchuk <anton.suprunchuk@gmail.com>
markin-io added a commit that referenced this pull request Apr 27, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Co-authored-by: shuplenkov <konstantin.shuplenkov@dash.org>
Co-authored-by: Djavid Gabibiyan <djavidoff@gmail.com>
Co-authored-by: Anton Suprunchuk <anton.suprunchuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants