Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): confirm votes on vote bit set receipt #779

Closed
wants to merge 2 commits into from

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Apr 23, 2024

Issue being fixed or feature implemented

Nodes mark votes as delivered directly after sending them to their peers, what is not always the case.

In case of high load, some votes might not be processed successfully and dropped (due to too long queue).
In this case, node will never these votes again, what can lead to chain halt on that node due to "starvation".

What was done?

Votes are not marked as delivered directly after sending. Instead, VoteSetBits message is sent after accepting a vote, and the peer marks vote as delivered after it received VoteSetBits.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link

github-actions bot commented May 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label May 4, 2024
@github-actions github-actions bot closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant