Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): connect to all other quorum members #864

Open
wants to merge 7 commits into
base: v1.2-dev
Choose a base branch
from

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Aug 8, 2024

Issue being fixed or feature implemented

Time between generation of a proposal and delivery to last validator is too high. To improve this, we can establish direct connections between all validators in the quorum.

What was done?

Implemented validator connection selector allValidatorsSelector that selects all validators in the quorum except self.

Introduced new config option:

[consensus]
# ValidatorConnectionAlgorithm defines the algorithm used to select the
# validators to which direct connection should be established.
# Possible values are:
# - "all" - validators establish direct connections to all other validators in the current quorum
# - "dip6" - validators establish direct connections to a subset of other validators, determined according to DIP-6
#
# Defaults to "dip6".
validator-connection-algorithm = "{{ .Consensus.ValidatorConnectionAlgorithm }}"

How Has This Been Tested?

NOT TESTED YET

Breaking Changes

None - backwards-compatible

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek added this to the v1.2 milestone Aug 8, 2024
@lklimek lklimek changed the title feat(dash): connect to all other quorum members feat(consensus): connect to all other quorum members Aug 8, 2024
@lklimek lklimek removed this from the v1.2 milestone Aug 12, 2024
Base automatically changed from fix/msg-queue-full to v1.2-dev August 12, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant